http://calcg.org/newlogo2.png Not Logged in.
Login | Register

General Discussion Board \ Site \ several changed to files.cgi

Click here to log in (you must be logged in to post comments).

AuthorComment
Barrett
Administrator
avatar
Posted: 23 Jan 2004
14:24 GMT
Total Posts: 1676
i fixed the website links so the target is _blank instead of _new... (i was gonna fix that about a year ago, but oh well).

and i changed around the review stuff. there was a bug where if you were on a 'view all' page and you clicked on "see more reviews" there was no id... i fixed that..... and there is no "see fewer reviews" option anymore... i didn't see a point to that... the user had already downloaded the page and had already scrolled down to the bottom... and also i made it use a horizontal rule instead of that weird =|=| thingy.... i still want it to be blue instead of gray... so i'll make that change some time soon.

so Z... make sure you don't overwrite files.cgi :happy:

and see those |'s up there? Z i'm guessing that's a bug in the replace script you made to teemz for the filter and smilies and stuff... i'll look at that and see what i can do (the |'s are supposed to be vertical bars)

[Edited by Barrett on 23-Jan-04 23:26]

---
-Barrett A
spiral
Wraith
Posted: 23 Jan 2004
15:23 GMT
Total Posts: 958
maintenance work is good i guess, I have no clue what you're talking about, but at least everything is working (or will be)
Barrett
Administrator
avatar
Posted: 23 Jan 2004
16:18 GMT
Total Posts: 1676
alright... now the lines are blue like they should be.

Z, i've spent TONS of time on files.cgi so be absolutely sure you redownload it before you do anything (in fact talk to me on AIM so we're not working at the same time.. i still have some stuff planned).

also, the 'review' field in the file database is not needed anymore. now it checks the review database for whether or not there is a review.... this was done to make the review managing scripts much easier (i'm gonna implement, for admins, the ability to remove reviews straight from the page).

this may make the scripts slower, but it's definitely not noticable, and this server's CPU is very good. i just talked to one of the managers to tell him there were 3 infinate loops running and he said cpu usage was only 3% (with infinate loops! on our old server it would have been 400% (don't ask how))

---
-Barrett A
Barrett
Administrator
avatar
Posted: 23 Jan 2004
16:48 GMT
Total Posts: 1676
ok i'm currently working on the delete review feature. (admins, you can use tfiles.cgi to check it out.... so far all it has is a link to a cgi file that does not exist (and it only shows up if you are an admin)).

what it'll end up doing is it'll open a new window and ask you to confirm... then when it deletes it'll send an email to the user who made the review asking them to make better reviews and blah blah blah.. maybe even a copy of the review.... that's all a lot of work but i think i can manage.

(i had too much chocolate.... that's why i'm working on stuff)

[Edited by Barrett on 24-Jan-04 01:48]

---
-Barrett A
Barrett
Administrator
avatar
Posted: 23 Jan 2004
17:28 GMT
Total Posts: 1676
alright admins, you can delete reviews. be sure you're deleting the correct one! (that's the point of the preview in the new window)

and don't delete left and right... only delete ones that do not follow directions and guidelines.

btw.... calculatorfreak..... how were you able to review pokemon vs digimon twice? i thought that was impossible...anyway, i deleted one, so they both got deleted (that's the way the script works... the review was fine, but you'll have to do it again)

[Edited by Barrett on 24-Jan-04 02:34]

---
-Barrett A
zkostik
Carrier
avatar
Posted: 23 Jan 2004
18:53 GMT
Total Posts: 2486
nice update B :)
don't worry, i won't overwrite it coz i always check the date. besides, i need to update my backup anyway so there you go. i'm glad you're back in business tho.

EDIT: very nifty what you've done with files.cgi! that was about time we got the review junk worked out anyway. excuse my laziness... oh yes, the new poll will roll out soon so we'll finally get rid of the popup window.

EDIT 2: B, add a few spaces between the admin options for reviews. as of now, i'll show up right next to the review title (if one exists). i suggest you just add a whole new line for the admin options, a style similar the the rating system should look pretty decent.
Oh, and you may want to add a number of total reviews next to show all. even though you can see the total reviews in review summary, having the number right next to the link would be a nice touch.

EDIT 3: We've had a few cases with double reviews before. I wasn't able to figure out how this happened since I wasn't able to do something like that myself. Well, maybe calcfreak would shed some light onto us?

[Edited by zkostik on 24-Jan-04 04:03]

---
09 F9 11 02 9D 74 E3 5B D8 41 56 C5 63 56 88 C0
calculatorfreakCG
Wraith
Posted: 23 Jan 2004
18:58 GMT
Total Posts: 739
Ummm . . .I havn't noticed anything new right now . . .I'm assuming the updates are only for the admins?
allynfolksjr
Administrator
avatar
Posted: 23 Jan 2004
21:36 GMT
Total Posts: 1892
thats what he said...
Barrett
Administrator
avatar
Posted: 23 Jan 2004
21:42 GMT
Total Posts: 1676
well, one thing you peons could notice is the breaks between reviews. They're much prettier. And you can also notice the lack of garbage reviews, cause i deleted about 30 of them.

---
-Barrett A
Barrett
Administrator
avatar
Posted: 23 Jan 2004
22:28 GMT
Total Posts: 1676
(and by the way, there were 2 good reviews that i had to delete because there were doubles... the way the script works made it impossible to keep one of the doubled reviews)

i believe one was calculator freak's review of pokemon vs. digimon... and i forget the other one, but i THINK it was one of allynfolksjr's reviews. it was like 4 hours ago so i don't remember for sure.

---
-Barrett A
allynfolksjr
Administrator
avatar
Posted: 23 Jan 2004
22:32 GMT
Total Posts: 1892
yah, i think is was one of mine that i double posted...
Barrett
Administrator
avatar
Posted: 23 Jan 2004
23:01 GMT
Total Posts: 1676
i fixed the review/double posting problems.

after people reviewed, it went to a list of all files here (instead of back to that file page).

it also didn't check the correct ID number for file currently being reviewed until after the error checking.

---
-Barrett A
spiral
Wraith
Posted: 24 Jan 2004
00:13 GMT
Total Posts: 958
First, I dont' see where the changes are, maybe i'm just not looking at it correctly.

*EDIT* nm, i see it now.

not really on the topic of this thread, but I thought html wasn't allowed in sigs?

[Edited by spiral on 24-Jan-04 09:20]
Barrett
Administrator
avatar
Posted: 24 Jan 2004
00:22 GMT
Total Posts: 1676
go here and you should see what we're talking about.

mostly what people will notice will be with files with multiple reviews.

spiral you should notice an ADMIN OPTION for all reviews for deleting the review.

[Edited by Barrett on 24-Jan-04 19:51]

---
-Barrett A
Digital
Guardian
avatar
Posted: 26 Jan 2004
12:30 GMT
Total Posts: 1051
Hey Barret, thanks for fixing up a whole lot of stuff before you leave. You've been busy this entire weekend. Great job, we all appreciate it.
spiral
Wraith
Posted: 26 Jan 2004
12:50 GMT
Total Posts: 958
Where's B leaving to?? Btw, I saw the deleting reviews thing.





Portal | My Account | Register | Lost Password or Username | TOS | Disclaimer | Help | Site Search | File Archives Copyright © 2002-2019 CalcG.org